Issue 233183002: Mark pub/test/serve/web_socket/url_to_asset_id_test slow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233183002: Mark pub/test/serve/web_socket/url_to_asset_id_test slow (Closed)

Created:
6 years, 8 months ago by ricow1

Modified:
6 years, 8 months ago

Reviewers:
Bob Nystrom, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Mark pub/test/serve/web_socket/url_to_asset_id_test slow This test has a todo to split it up into smaller components I don't know what has triggered this to go over the limit more easily R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=34924

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sdk/lib/_internal/pub/pub.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

ricow1

Committed patchset #1 manually as r34924 (presubmit successful).

6 years, 8 months ago (2014-04-10 12:59:44 UTC) #3

Bob Nystrom

6 years, 8 months ago (2014-04-10 15:50:08 UTC) #4

Message was sent while issue was closed.

LGTM, though the perf degradation is a bit alarming. I'll look into it.