Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 23314005: Fix test that contains compile-time error. (Closed)

Created:
7 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix test that contains compile-time error. This doesn't affect dart2js, which fails to detect the compile-time error. Filing separate bug for that. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M tests/language/compile_time_constant10_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 4 months ago (2013-08-21 14:05:10 UTC) #1
Søren Gjesse
lgtm
7 years, 4 months ago (2013-08-21 14:13:30 UTC) #2
Lasse Reichstein Nielsen
7 years, 4 months ago (2013-08-21 14:29:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26430 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698