Issue 233093004: - Apply review comments from https://codereview.chromium.org/232223004/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 233093004: - Apply review comments from https://codereview.chromium.org/232223004/ (Closed)

Created:
6 years, 8 months ago by Ivan Posva

Modified:
6 years, 8 months ago

Reviewers:
Anders Johnsen, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Apply review comments from https://codereview.chromium.org/232223004/ - Use isWindows where appropriate. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=34934

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -22 lines)			Patch
M	runtime/bin/process_patch.dart	View	7 chunks	+29 lines, -14 lines	1 comment	Download
M	sdk/lib/io/file_system_entity.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/link.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/platform.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, Thank you, very nice cleanup. https://codereview.chromium.org/233093004/diff/1/runtime/bin/process_patch.dart File runtime/bin/process_patch.dart (right): https://codereview.chromium.org/233093004/diff/1/runtime/bin/process_patch.dart#newcode196 runtime/bin/process_patch.dart:196: environment = (environment ...

6 years, 8 months ago (2014-04-10 16:41:20 UTC) #2

Ivan Posva

6 years, 8 months ago (2014-04-10 17:49:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34934 (presubmit successful).

Expand Messages | Collapse Messages