Formatter checkpoint.

Formatter checkpoint.

Largely cleanup in a move from string literals to accessing the corresponding node tokens.

I'm also trying on an approach to tracking the need for preceding (and trailing) newlines.  In general I don't love state flags where I can avoid them but the alternatives were even more ungainly to my eye.

Thoughts, of course, are most welcome!

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26370

[Brian Wilkerson, 2013-08-20 15:46:39]

LGTM.

I also dislike the state flags. I have to wonder whether we couldn't get rid of
the need for them by moving control back to the parent of the nodes where the
state is being set.

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:543: append(';');
Correct. The semicolon is part of the function body (if it's an expression) or
not allowed if the body is a block. If the user types

  f() { ... };

the trailing semicolon is actually an empty statement. (You might need to treat
empty statements specially.)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:617:
append('..');
token(node.period)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:639:
append('\${');
token(node.leftBracket)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:641: append('}');
token(node.rightBracket)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:643:
append('\$');
token(node.leftBracket)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:726:
append('..');
token(node.period)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:794:
append('..');
token(node.period)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:797: append('.');
token(node.period)

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/test/services/formatter_test.dart:167: 'if (true)
{\nreturn 42;\n'
It seems like it would be easier to read the tests if there were only
line-breaks at the end of the line.

[pquitslund, 2013-08-20 16:49:35]

Awesome.

Thanks Brian!

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:543: append(';');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> Correct. The semicolon is part of the function body (if it's an expression) or
> not allowed if the body is a block. If the user types
> 
>   f() { ... };
> 
> the trailing semicolon is actually an empty statement. (You might need to
treat
> empty statements specially.)

Good deal.  Thanks for the clarification!

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:617:
append('..');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.period)

Done.

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:639:
append('\${');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.leftBracket)

Done.

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:641: append('}');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.rightBracket)

Done.

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:643:
append('\$');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.leftBracket)

Done.

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:726:
append('..');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.period)

Done.

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:794:
append('..');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.period)

Turns out it's:
 
  token(node.operator);

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:797: append('.');
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> token(node.period)

Turns out it's:
 
  token(node.operator);

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
File pkg/analyzer_experimental/test/services/formatter_test.dart (right):

https://codereview.chromium.org/23308004/diff/5001/pkg/analyzer_experimental/...
pkg/analyzer_experimental/test/services/formatter_test.dart:167: 'if (true)
{\nreturn 42;\n'
On 2013/08/20 15:46:39, Brian Wilkerson wrote:
> It seems like it would be easier to read the tests if there were only
> line-breaks at the end of the line.

Agreed.  I'll do a test cleanup pass soon.

[pquitslund, 2013-08-20 16:50:07]

Committed patchset #4 manually as r26370 (presubmit successful).