Formatter checkpoint (String literal elimination).

Formatter checkpoint.

Some fixes and a progress towards the elimination of references to String literals in visit methods.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26608

[Brian Wilkerson, 2013-08-23 19:25:48]

LGTM

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:229: }
Should this (eventually) be

  visitNodes(node.statements, precededBy: newlines, separatedBy: newlines);

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:362: node.period;
Remove this line?

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:535: space();
Do we always want a space, or only then there is a condition (ie. "x;; y" vs "x;
; y")?

[pquitslund, 2013-08-23 20:16:08]

Thanks!

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/src/services/formatter_impl.dart (right):

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:229: }
On 2013/08/23 19:25:48, Brian Wilkerson wrote:
> Should this (eventually) be
> 
>   visitNodes(node.statements, precededBy: newlines, separatedBy: newlines);

No time like now! :)  Thanks for the catch.

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:362: node.period;
On 2013/08/23 19:25:48, Brian Wilkerson wrote:
> Remove this line?

Done.

https://codereview.chromium.org/23301021/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/src/services/formatter_impl.dart:535: space();
On 2013/08/23 19:25:48, Brian Wilkerson wrote:
> Do we always want a space, or only then there is a condition (ie. "x;; y" vs
"x;
> ; y")?

Great question.  My gut is always.  Happy to be swayed by popular opinion though
when the time comes!

[pquitslund, 2013-08-23 20:17:21]

Committed patchset #2 manually as r26608 (presubmit successful).