Issue 23301012: Revert "Revert "Adding polyfill support for custom elements.""

Issue 23301012: Revert "Revert "Adding polyfill support for custom elements."" (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 4 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Adding polyfill support for custom elements."" This fixes the issues in the custom elements polyfills. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=26412

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1602 lines, -20 lines)			Patch
A	pkg/custom_element/lib/custom-elements.debug.js	View	1 chunk	+1458 lines, -0 lines	0 comments	Download
A	pkg/custom_element/lib/custom-elements.min.js	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	6 chunks	+31 lines, -9 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+21 lines, -4 lines	0 comments	Download
M	tests/html/custom_elements_test.dart	View	4 chunks	+16 lines, -2 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/src/dart2js_CustomElementSupport.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/dom/src/dart2js_Platform.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tools/dom/src/dartium_Platform.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Document.darttemplate	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	2 chunks	+15 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

https://codereview.chromium.org/23301012/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (right): https://codereview.chromium.org/23301012/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#newcode1176 tools/dom/templates/html/impl/impl_Element.darttemplate:1176: @DomName('HTMLElement.innerHTML') Issue was that the native dart2js impl for ...

7 years, 4 months ago (2013-08-20 23:47:43 UTC) #1

blois

7 years, 4 months ago (2013-08-21 00:08:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r26412 (presubmit successful).

Expand Messages | Collapse Messages