Issue 23300004: Added Dart API methods:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23300004: Added Dart API methods: (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added Dart API methods: Dart_GetNativeIntegerArgument Dart_GetNativeDoubleArgument Dart_GetNativeBooleanArgument R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26485

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -2 lines)			Patch
M	runtime/include/dart_api.h	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	1 chunk	+102 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View		1 chunk	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/23300004/diff/5001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/23300004/diff/5001/runtime/vm/dart_api_impl.cc#newcode3752 runtime/vm/dart_api_impl.cc:3752: "%s: argument %d is not an Integer argument.", ...

7 years, 4 months ago (2013-08-21 22:58:43 UTC) #2

siva

https://codereview.chromium.org/23300004/diff/5001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/23300004/diff/5001/runtime/vm/dart_api_impl.cc#newcode3752 runtime/vm/dart_api_impl.cc:3752: "%s: argument %d is not an Integer argument.", Good ...

7 years, 4 months ago (2013-08-21 23:08:57 UTC) #3

siva

7 years, 4 months ago (2013-08-21 23:20:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r26485 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23300004: Added Dart API methods: (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages