Issue 23295025: Handle invalid version syntax in pubspecs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23295025: Handle invalid version syntax in pubspecs. (Closed)

Created:
7 years, 4 months ago by Bob Nystrom

Modified:
7 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle invalid version syntax in pubspecs. BUG=https://code.google.com/p/dart/issues/detail?id=11046 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26541

Patch Set 2 : Refactor a bit. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -13 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/pubspec.dart	View	1	5 chunks	+39 lines, -13 lines	0 comments	Download
	M	sdk/lib/_internal/pub/test/pubspec_test.dart	View		2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

One suggestion, otherwise lgtm. https://codereview.chromium.org/23295025/diff/1/sdk/lib/_internal/pub/lib/src/pubspec.dart File sdk/lib/_internal/pub/lib/src/pubspec.dart (right): https://codereview.chromium.org/23295025/diff/1/sdk/lib/_internal/pub/lib/src/pubspec.dart#newcode306 sdk/lib/_internal/pub/lib/src/pubspec.dart:306: } Factor this out into ...

7 years, 4 months ago (2013-08-22 00:20:05 UTC) #2

Bob Nystrom

Thanks! https://codereview.chromium.org/23295025/diff/1/sdk/lib/_internal/pub/lib/src/pubspec.dart File sdk/lib/_internal/pub/lib/src/pubspec.dart (right): https://codereview.chromium.org/23295025/diff/1/sdk/lib/_internal/pub/lib/src/pubspec.dart#newcode306 sdk/lib/_internal/pub/lib/src/pubspec.dart:306: } On 2013/08/22 00:20:05, nweiz wrote: > Factor ...

7 years, 4 months ago (2013-08-22 18:05:39 UTC) #3

Bob Nystrom

7 years, 4 months ago (2013-08-22 18:05:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26541 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23295025: Handle invalid version syntax in pubspecs. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Refactor a bit. #

Messages