Issue 23295016: Fix for issue 12489.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23295016: Fix for issue 12489. (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tools/dom/scripts/systemnative.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

vsm

lgtm It may be worth changing the name of Dart_SetIntegerReturnValue to make it clear that ...

7 years, 4 months ago (2013-08-19 17:55:20 UTC) #2

siva

Will do the name change in another CL as it requires a Dart API change. ...

7 years, 4 months ago (2013-08-19 18:50:48 UTC) #3

siva

7 years, 4 months ago (2013-08-19 20:44:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26327 (presubmit successful).