Add index consistency check to source map validation tests.

Add index consistency check to source map validation tests.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35012

[Johnni Winther, 2014-04-10 12:55:00]

lgtm

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
File tests/compiler/dart2js/source_map_validator_helper.dart (right):

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:33:
Expect.isTrue(line.line < target.length);
Check that line.line >= 1 (or is it 0?)

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:40: //
Expect.isTrue(entry.column < target[line.line].length);
Check entry.column >= 1 (or 0?)

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:41:
Expect.isTrue(urlIndex == null || urlIndex < urlsLength);
Check urlIndex >= 0.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:43: entry.sourceLine <
sources[urlIndex].length);
Check entry.sourceLine >= 1 (or 1?).

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:45: entry.sourceColumn <
sources[urlIndex][entry.sourceLine].length);
Ditto.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:47: entry.sourceNameId <
sourceMap.names.length);
Ditto.

[zarah, 2014-04-10 13:46:19]

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
File tests/compiler/dart2js/source_map_validator_helper.dart (right):

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:33:
Expect.isTrue(line.line < target.length);
On 2014/04/10 12:55:01, Johnni Winther wrote:
> Check that line.line >= 1 (or is it 0?)

Done.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:40: //
Expect.isTrue(entry.column < target[line.line].length);
On 2014/04/10 12:55:01, Johnni Winther wrote:
> Check entry.column >= 1 (or 0?)

Done.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:41:
Expect.isTrue(urlIndex == null || urlIndex < urlsLength);
On 2014/04/10 12:55:01, Johnni Winther wrote:
> Check urlIndex >= 0.

Done.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:43: entry.sourceLine <
sources[urlIndex].length);
On 2014/04/10 12:55:01, Johnni Winther wrote:
> Check entry.sourceLine >= 1 (or 1?).

Done.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:45: entry.sourceColumn <
sources[urlIndex][entry.sourceLine].length);
On 2014/04/10 12:55:01, Johnni Winther wrote:
> Ditto.

Done.

https://codereview.chromium.org/232943003/diff/20001/tests/compiler/dart2js/s...
tests/compiler/dart2js/source_map_validator_helper.dart:47: entry.sourceNameId <
sourceMap.names.length);
On 2014/04/10 12:55:01, Johnni Winther wrote:
> Ditto.

Done.

[zarah, 2014-04-14 07:38:42]

Committed patchset #3 manually as r35012 (presubmit successful).