Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 23291002: Fix pub serve on windows. (Closed)

Created:
7 years, 4 months ago by Bob Nystrom
Modified:
7 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix pub serve on windows. BUG=https://code.google.com/p/dart/issues/detail?id=12500 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M sdk/lib/_internal/pub/lib/src/command/serve.dart View 3 chunks +12 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/pub.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I wasn't correctly converting a windows path to an asset ID. :(
7 years, 4 months ago (2013-08-16 17:09:20 UTC) #1
Bob Nystrom
7 years, 4 months ago (2013-08-16 17:09:28 UTC) #2
nweiz
lgtm
7 years, 4 months ago (2013-08-16 19:12:10 UTC) #3
Bob Nystrom
7 years, 4 months ago (2013-08-16 20:42:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698