co19-roll to r546

co19-roll to r546

R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26259

[kustermann, 2013-08-16 08:28:14]

I'm doing it slightly differently than peter used to do. I hope that's ok.

There seem to be a few renamed files that failed before and still fail. Some of
these had co19 issue numbers attached.
Despite that fact, I removed the old lines and made new lines with "please
triage this failure". The reason for this is that some tests fail now for a
different reason.

[ricow1, 2013-08-16 08:35:19]

LGTM

[kustermann, 2013-08-16 08:36:51]

Committed patchset #1 manually as r26259 (presubmit successful).

[ahe, 2013-08-16 08:39:43]

Comments about what I could see on my phone. I'll take a more careful look later
today.

https://codereview.chromium.org/23283003/diff/1/dart/tests/co19/co19-analyzer...
File dart/tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/23283003/diff/1/dart/tests/co19/co19-analyzer...
dart/tests/co19/co19-analyzer.status:126: # co19-roll r546 (11.08.2013) caused
these failures
Generally, I tend to avoid "section" comments like these. They tend to slow down
the update process. 

Also, you highly recommend that you add: TODO(team-name) on each "please triage"
line. This helps the teams remember who is supposed to triage the bugs.

[kustermann, 2013-08-16 09:01:19]

On 2013/08/16 08:39:43, ahe wrote:
> Comments about what I could see on my phone. I'll take a more careful look
later
> today.
> 
>
https://codereview.chromium.org/23283003/diff/1/dart/tests/co19/co19-analyzer...
> File dart/tests/co19/co19-analyzer.status (right):
> 
>
https://codereview.chromium.org/23283003/diff/1/dart/tests/co19/co19-analyzer...
> dart/tests/co19/co19-analyzer.status:126: # co19-roll r546 (11.08.2013) caused
> these failures
> Generally, I tend to avoid "section" comments like these. They tend to slow
down
> the update process. 
> 
> Also, you highly recommend that you add: TODO(team-name) on each "please
triage"
> line. This helps the teams remember who is supposed to triage the bugs.

Now I landed it. But we can talk more about this when you're in the office. I
can change the comments if it is *really* necessary.