Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 232823002: Allow closures in string literals in initializer expressions. (Closed)

Created:
6 years, 8 months ago by floitsch
Modified:
6 years, 8 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow closures in string literals in initializer expressions. BUG= http://dartbug.com/18102 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=34919

Patch Set 1 #

Patch Set 2 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
A tests/language/parse_closures_in_initializers_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
6 years, 8 months ago (2014-04-10 09:54:38 UTC) #1
Johnni Winther
lgtm
6 years, 8 months ago (2014-04-10 10:21:12 UTC) #2
floitsch
6 years, 8 months ago (2014-04-10 11:50:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698