Issue 23276003: Updating custom element's preregister test to follow new contracts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23276003: Updating custom element's preregister test to follow new contracts. (Closed)

Created:
7 years, 4 months ago by blois

Modified:
7 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updating custom element's preregister test to follow new contracts. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=26290

Patch Set 2 : Removing analyzer test skip. #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
	M	tests/html/custom_elements_test.dart	View		3 chunks	+5 lines, -4 lines	2 comments	Download
	M	tests/html/html.status	View	1	2 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

Tested and passing on Dartium & dart2js, just cleaning this up so it's less noise ...

7 years, 4 months ago (2013-08-16 17:46:04 UTC) #1

vsm

lgtm - but do we want to stick with the current behavior? https://codereview.chromium.org/23276003/diff/4001/tests/html/custom_elements_test.dart File tests/html/custom_elements_test.dart ...

7 years, 4 months ago (2013-08-16 18:28:50 UTC) #2

blois

https://codereview.chromium.org/23276003/diff/4001/tests/html/custom_elements_test.dart File tests/html/custom_elements_test.dart (right): https://codereview.chromium.org/23276003/diff/4001/tests/html/custom_elements_test.dart#newcode118 tests/html/custom_elements_test.dart:118: expect(firedOnPre, isTrue); On 2013/08/16 18:28:51, vsm wrote: > This ...

7 years, 4 months ago (2013-08-16 19:45:48 UTC) #3

blois

7 years, 4 months ago (2013-08-16 19:46:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26290 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23276003: Updating custom element's preregister test to follow new contracts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Removing analyzer test skip. #

Messages