Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 23272002: Command to print paths to dependencies. (Closed)

Created:
7 years, 4 months ago by Bob Nystrom
Modified:
7 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Command to print paths to dependencies. BUG=https://code.google.com/p/dart/issues/detail?id=12354 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=26287

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove unused variable. #

Messages

Total messages: 4 (0 generated)
Bob Nystrom
7 years, 4 months ago (2013-08-15 23:10:27 UTC) #1
nweiz
A couple comments, otherwise lgtm. https://codereview.chromium.org/23272002/diff/1/sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart File sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart (right): https://codereview.chromium.org/23272002/diff/1/sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart#newcode24 sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart:24: allowed: ["json"]); Let's add ...
7 years, 4 months ago (2013-08-16 00:41:33 UTC) #2
Bob Nystrom
Thanks! https://codereview.chromium.org/23272002/diff/1/sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart File sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart (right): https://codereview.chromium.org/23272002/diff/1/sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart#newcode24 sdk/lib/_internal/pub/lib/src/command/list_package_dirs.dart:24: allowed: ["json"]); On 2013/08/16 00:41:33, nweiz wrote: > ...
7 years, 4 months ago (2013-08-16 18:17:39 UTC) #3
Bob Nystrom
7 years, 4 months ago (2013-08-16 18:17:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698