Attach to window, add some editable markers, and add a license file.

Attach to window, add some editable markers, and add a license file.

Attach the listener to the window, so listeners and handlers on the
document get called first. Add designMode, and fix the
webkit-user-modify test to look at the right property and handle all
applicable values. Add a license file.

BUG=645510, 644885
R=ojan@chromium.org

Committed: https://chromium.googlesource.com/chromium/extensions-by-google/6f469617da17dabf26b93c44a0457a6ca5c5f57d

[Pam (message me for reviews), 2016-09-09 17:47:37]

Description was changed from

==========
Attach to window, add some editable markers, and add a license file.

Attach the listener to the window, so listeners and handlers on the
document get called first. Add designMode, and fix the
webkit-user-modify test to look at the right property and handle all
applicable values. Add a license file.

BUG=645510, 644885
==========

to

==========
Attach to window, add some editable markers, and add a license file.

Attach the listener to the window, so listeners and handlers on the
document get called first. Add designMode, and fix the
webkit-user-modify test to look at the right property and handle all
applicable values. Add a license file.

BUG=645510, 644885
==========

[Pam (message me for reviews), 2016-09-09 17:47:37]

pam@chromium.org changed reviewers:
+ ojan@chromium.org

[Pam (message me for reviews), 2016-09-09 17:47:51]

Hi Ojan! Another small one. Thanks again.

[ojan, 2016-09-09 18:06:31]

lgtm

https://codereview.chromium.org/2326083002/diff/1/go-back-with-backspace/cont...
File go-back-with-backspace/content_script.js (right):

https://codereview.chromium.org/2326083002/diff/1/go-back-with-backspace/cont...
go-back-with-backspace/content_script.js:12:
!isEditable(document.activeElement)) {
This won't do the right thing with shadow DOM.
 
http://plexode.com/eval3/#s=aekVQXANJVQMbAx1yAUpFHj0DVElCjFgOSVBUVZsfHRByHwMN...

e.path is doing something funky here. We should followup with shadow DOM people
to understand if this is really the right behavior.

In the meantime, I think there's much more content that depends on the issue
you're addressing than content that has text controls in shadow DOM. So, I think
this change is good, but needs a TODO to make work with shadow DOM once we've
worked things out there. Filed crbug.com/645527.

[Pam (message me for reviews), 2016-09-09 18:46:15]

On 2016/09/09 18:06:31, ojan wrote:
> lgtm
> 
>
https://codereview.chromium.org/2326083002/diff/1/go-back-with-backspace/cont...
> File go-back-with-backspace/content_script.js (right):
> 
>
https://codereview.chromium.org/2326083002/diff/1/go-back-with-backspace/cont...
> go-back-with-backspace/content_script.js:12:
> !isEditable(document.activeElement)) {
> This won't do the right thing with shadow DOM.
>  
>
http://plexode.com/eval3/#s=aekVQXANJVQMbAx1yAUpFHj0DVElCjFgOSVBUVZsfHRByHwMN...
> 
> e.path is doing something funky here. We should followup with shadow DOM
people
> to understand if this is really the right behavior.
> 
> In the meantime, I think there's much more content that depends on the issue
> you're addressing than content that has text controls in shadow DOM. So, I
think
> this change is good, but needs a TODO to make work with shadow DOM once we've
> worked things out there. Filed crbug.com/645527.

Done -- thanks!

[Pam (message me for reviews), 2016-09-09 18:46:35]

Description was changed from

==========
Attach to window, add some editable markers, and add a license file.

Attach the listener to the window, so listeners and handlers on the
document get called first. Add designMode, and fix the
webkit-user-modify test to look at the right property and handle all
applicable values. Add a license file.

BUG=645510, 644885
==========

to

==========
Attach to window, add some editable markers, and add a license file.

Attach the listener to the window, so listeners and handlers on the
document get called first. Add designMode, and fix the
webkit-user-modify test to look at the right property and handle all
applicable values. Add a license file.

BUG=645510, 644885
R=ojan@chromium.org

Committed:
https://chromium.googlesource.com/chromium/extensions-by-google/6f469617da17d...
==========

[Pam (message me for reviews), 2016-09-09 18:46:36]

Committed patchset #2 (id:20001) manually as
6f469617da17dabf26b93c44a0457a6ca5c5f57d (presubmit successful).