Issue 23258002: Load builtin helper libraries on demand.

Issue 23258002: Load builtin helper libraries on demand. (Closed)

Created:
7 years, 4 months ago by zarah

Modified:
7 years, 3 months ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Load builtin helper libraries on demand. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26309

Patch Set 2 : Addressed review comments. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -12 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	4 chunks	+9 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
A	tests/compiler/dart2js/library_load_test.dart	View	1	1 chunk	+34 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/memory_compiler.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

DBC https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode728 sdk/lib/_internal/compiler/implementation/compiler.dart:728: } Nit: Keep the else/if syntax. https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode734 sdk/lib/_internal/compiler/implementation/compiler.dart:734: ...

7 years, 4 months ago (2013-08-15 19:13:02 UTC) #2

ahe

LGTM once you address Nicolas' and mine comments. https://codereview.chromium.org/23258002/diff/1/tests/compiler/dart2js/library_load_test.dart File tests/compiler/dart2js/library_load_test.dart (right): https://codereview.chromium.org/23258002/diff/1/tests/compiler/dart2js/library_load_test.dart#newcode9 tests/compiler/dart2js/library_load_test.dart:9: ScanMockCompiler() ...

7 years, 4 months ago (2013-08-19 08:48:53 UTC) #3

zarah

Committed patchset #2 manually as r26309 (presubmit successful).

7 years, 4 months ago (2013-08-19 08:58:26 UTC) #4

zarah

7 years, 3 months ago (2013-08-28 10:20:13 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:728: }
On 2013/08/15 19:13:02, ngeoffray wrote:
> Nit: Keep the else/if syntax.

Done.

https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:734: && (uri == new
Uri(scheme: 'dart', path: '_foreign_helper'))) {
On 2013/08/15 19:13:02, ngeoffray wrote:
> Nit: '&&' at the same indentation as foreignLibrary === null

Done.

https://codereview.chromium.org/23258002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:845: interceptorsLibrary
= scanBuiltinLibrary('_interceptors');
On 2013/08/15 19:13:02, ngeoffray wrote:
> What about those two? Do you plan on moving them? Are there some restrictions
> that prevent moving them?

The jsHelperLibrary is used just below and the interceptorsLibrary is used in
findInterceptor() so they cannot be moved unfortunately.

https://codereview.chromium.org/23258002/diff/1/tests/compiler/dart2js/librar...
File tests/compiler/dart2js/library_load_test.dart (right):

https://codereview.chromium.org/23258002/diff/1/tests/compiler/dart2js/librar...
tests/compiler/dart2js/library_load_test.dart:9: ScanMockCompiler() {
On 2013/08/19 08:48:53, ahe wrote:
> Weird indentation.

Done.

https://codereview.chromium.org/23258002/diff/1/tests/compiler/dart2js/librar...
tests/compiler/dart2js/library_load_test.dart:10: isolateHelperLibrary = null;
On 2013/08/19 08:48:53, ahe wrote:
> Ditto.

Done.

https://codereview.chromium.org/23258002/diff/1/tests/compiler/dart2js/librar...
tests/compiler/dart2js/library_load_test.dart:13: LibraryElement
scanBuiltinLibrary(String filename) {
On 2013/08/19 08:48:53, ahe wrote:
> Add empty line before this method.

Done.

Expand Messages | Collapse Messages