Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 23253004: Fix error in SecureSocket, remove failing status from tests. (Closed)

Created:
7 years, 4 months ago by Bill Hesse
Modified:
7 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix error in SecureSocket, remove failing status from tests. BUG=dartbug.com/12451 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M sdk/lib/io/secure_socket.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
If the RawSocket.connect completed with an error, we dropped it, because we thought we were ...
7 years, 4 months ago (2013-08-20 12:01:29 UTC) #1
Søren Gjesse
LGTM!
7 years, 4 months ago (2013-08-20 12:42:36 UTC) #2
Bill Hesse
7 years, 4 months ago (2013-08-20 12:54:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698