Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 23245015: Remove entries in status refering to non-existent files (Closed)

Created:
7 years, 4 months ago by kustermann
Modified:
7 years, 4 months ago
Reviewers:
ricow1, Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove entries in status refering to non-existent files R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=26438

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M dart/pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M dart/tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +0 lines, -1 line 0 comments Download
M dart/tests/html/html.status View 5 chunks +0 lines, -11 lines 0 comments Download
M dart/tests/isolate/isolate.status View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/language/language.status View 3 chunks +0 lines, -4 lines 0 comments Download
M dart/tests/language/language_analyzer.status View 2 chunks +0 lines, -4 lines 0 comments Download
M dart/tests/language/language_analyzer2.status View 2 chunks +0 lines, -4 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 7 chunks +0 lines, -14 lines 0 comments Download
M dart/tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
kustermann
7 years, 4 months ago (2013-08-21 16:34:29 UTC) #1
ricow1
lgtm Should we check in the script to find these?
7 years, 4 months ago (2013-08-21 16:36:28 UTC) #2
kustermann
On 2013/08/21 16:36:28, ricow1 wrote: > lgtm > Should we check in the script to ...
7 years, 4 months ago (2013-08-21 16:39:10 UTC) #3
kustermann
Committed patchset #2 manually as r26438 (presubmit successful).
7 years, 4 months ago (2013-08-21 16:40:55 UTC) #4
Søren Gjesse
LGTM How about checking references in multi-tests as well? Don't know how many there might ...
7 years, 4 months ago (2013-08-21 19:51:33 UTC) #5
kustermann
7 years, 4 months ago (2013-08-21 20:39:23 UTC) #6
Message was sent while issue was closed.
On 2013/08/21 19:51:33, Søren Gjesse wrote:
> LGTM
> 
> How about checking references in multi-tests as well? Don't know how many
there
> might be, but I have seen a few.

That's a great idea. I'll look into it.

Powered by Google App Engine
This is Rietveld 408576698