Issue 23241016: Actually use the new browser controller on the normal waterfall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23241016: Actually use the new browser controller on the normal waterfall. (Closed)

Created:
7 years, 4 months ago by ricow1

Modified:
7 years, 4 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Actually use the new browser controller on the normal waterfall. Committed: https://code.google.com/p/dart/source/detail?r=26510

Patch Set 1 #

Total comments: 3

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/bots/compiler.py	View		1 chunk	+2 lines, -2 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #1 manually as r26510 (presubmit successful).

7 years, 4 months ago (2013-08-22 09:08:32 UTC) #3

kustermann

lgtm https://codereview.chromium.org/23241016/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/23241016/diff/1/tools/bots/compiler.py#newcode122 tools/bots/compiler.py:122: 'windows': ['ie9'] You must be kidding, I thought ...

7 years, 4 months ago (2013-08-22 09:14:21 UTC) #4

ricow1

7 years, 4 months ago (2013-08-22 09:39:37 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/23241016/diff/1/tools/bots/compiler.py
File tools/bots/compiler.py (right):

https://codereview.chromium.org/23241016/diff/1/tools/bots/compiler.py#newcod...
tools/bots/compiler.py:128: 'windows': []
On 2013/08/22 09:14:21, kustermann wrote:
> So we don't use the new controller for ie10?

No, not yet

Expand Messages | Collapse Messages