Issue 23241004: Remove prefixes on Intl.message calls within Intl.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23241004: Remove prefixes on Intl.message calls within Intl.dart (Closed)

Created:
7 years, 4 months ago by Alan Knight

Modified:
7 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

If you have something that recursively looks for messages in dependencies, it can end up parsing intl.dart and giving warnings that there are invalid messages in its internals. Change the calls to invoke the static messages without a prefix so that this won't complain. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26233

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix line length #

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
	M	pkg/intl/lib/intl.dart	View	1	5 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with one tweak! https://codereview.chromium.org/23241004/diff/1/pkg/intl/lib/intl.dart File pkg/intl/lib/intl.dart (right): https://codereview.chromium.org/23241004/diff/1/pkg/intl/lib/intl.dart#newcode276 pkg/intl/lib/intl.dart:276: * Format a message differently ...

7 years, 4 months ago (2013-08-15 21:59:12 UTC) #2

Alan Knight

https://codereview.chromium.org/23241004/diff/1/pkg/intl/lib/intl.dart File pkg/intl/lib/intl.dart (right): https://codereview.chromium.org/23241004/diff/1/pkg/intl/lib/intl.dart#newcode276 pkg/intl/lib/intl.dart:276: * Format a message differently depending on [targetGender]. Normally ...

7 years, 4 months ago (2013-08-15 22:27:32 UTC) #3

Alan Knight

7 years, 4 months ago (2013-08-15 22:28:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r26233 (presubmit successful).

Expand Messages | Collapse Messages