Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232373002: pkg/polymer[_expressions] unittest fixes (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/polymer[_expressions] unittest fixes R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34908

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M pkg/polymer/lib/polymer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/build/script_compactor.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M pkg/polymer/test/bind_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/entered_view_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/event_handlers_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/mirror_loader_1.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/mirror_loader_2.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/mirror_loader_3.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/mirror_loader_4.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/mirror_loader_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/nested_binding_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/property_change_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/test/property_observe_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer_expressions/test/bindings_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer_expressions/test/syntax_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevmoo
Fixed a bunch of deprecations and warnings, too
6 years, 8 months ago (2014-04-09 23:58:38 UTC) #1
Siggi Cherem (dart-lang)
other than the comment below, looks good https://codereview.chromium.org/232373002/diff/1/pkg/polymer/lib/src/build/script_compactor.dart File pkg/polymer/lib/src/build/script_compactor.dart (left): https://codereview.chromium.org/232373002/diff/1/pkg/polymer/lib/src/build/script_compactor.dart#oldcode27 pkg/polymer/lib/src/build/script_compactor.dart:27: import 'package:polymer_expressions/expression.dart' ...
6 years, 8 months ago (2014-04-10 00:05:03 UTC) #2
kevmoo
PTAL
6 years, 8 months ago (2014-04-10 00:12:39 UTC) #3
Siggi Cherem (dart-lang)
lgtm
6 years, 8 months ago (2014-04-10 00:20:15 UTC) #4
kevmoo
6 years, 8 months ago (2014-04-10 00:22:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r34908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698