Issue 23224015: editor build change to suppress a 'restore windows' dialog on the mac buildbots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23224015: editor build change to suppress a 'restore windows' dialog on the mac buildbots (Closed)

Created:
7 years, 4 months ago by devoncarew

Modified:
7 years, 3 months ago

Reviewers:
danrubel, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

editor build change to suppress a 'restore windows' dialog on the mac buildbots R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=26793

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -0 lines)			Patch
	M	editor/build/build.py	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	M	tools/bots/editor.py	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

devoncarew

Committed patchset #2 manually as r26793 (presubmit successful).

7 years, 3 months ago (2013-08-28 15:23:14 UTC) #3

kustermann

LGTM. Sorry, I forgot about this CL. A thing I was wondering is the following: ...

7 years, 3 months ago (2013-08-28 15:32:13 UTC) #4

kustermann

7 years, 3 months ago (2013-08-28 15:40:20 UTC) #5

Message was sent while issue was closed.

On 2013/08/28 15:32:13, kustermann wrote:
> LGTM.
> 
> Sorry, I forgot about this CL.
> 
> A thing I was wondering is the following:
> Back then when we hit this issue the first time, I executed this "defaults
..."
> command. And it should be a permanent setting. This makes me believe that it
> might not solve our issues.

Well, not in this case. 'dart-editor-mac' and 'dart-editor-mac-trunk' run on the
same VM: vm683-m3 (and we haven't changed that assignment for a long time).

Expand Messages | Collapse Messages