Issue 23220007: Update meta and logging library descriptions; tweak fixnum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23220007: Update meta and logging library descriptions; tweak fixnum (Closed)

Created:
7 years, 4 months ago by Kathy Walrath

Modified:
7 years, 4 months ago

Reviewers:
mem

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update meta and logging library descriptions; tweak fixnum R=mcampione@google.com Committed: https://code.google.com/p/dart/source/detail?r=26562

Patch Set 2 : tweak meta one-liner #

Total comments: 1

Patch Set 4 : incorporate mem's comment #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -35 lines)			Patch
M	pkg/fixnum/lib/fixnum.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/lib/logging.dart	View	1 2 3	1 chunk	+7 lines, -17 lines	0 comments	Download
M	pkg/meta/lib/meta.dart	View	1	1 chunk	+14 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mem

one mini-comment. lgtm otherwise. memzie https://chromiumcodereview.appspot.com/23220007/diff/3001/pkg/logging/lib/logging.dart File pkg/logging/lib/logging.dart (right): https://chromiumcodereview.appspot.com/23220007/diff/3001/pkg/logging/lib/logging.dart#newcode12 pkg/logging/lib/logging.dart:12: * For information on ...

7 years, 4 months ago (2013-08-22 21:22:18 UTC) #2

Kathy Walrath

7 years, 4 months ago (2013-08-22 22:17:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r26562 (presubmit successful).