Issue 23218004: Changes required for Dartium roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23218004: Changes required for Dartium roll (Closed)

Created:
7 years, 4 months ago by Jacob

Modified:
7 years, 2 months ago

Reviewers:
vsm, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Changes required for Dartium roll BUG=

Patch Set 1 : ready to review #

Patch Set 2 : code review fixes #

Patch Set 3 : expectation_file_tweaks #

Patch Set 4 : status tweak #

Patch Set 5 : fix last typo #

Patch Set 6 : tweak expectations file #

Patch Set 7 : Update status file #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	pkg/pkg.status	View	1 2 3 4 5 6	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

7 years, 4 months ago (2013-08-19 19:40:18 UTC) #2

lgtm

https://codereview.chromium.org/23218004/diff/7001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/23218004/diff/7001/tests/html/html.status#new...
tests/html/html.status:14: custom_elements_test/preregister: Fail
I think this test is already semi-broken,

https://codereview.chromium.org/23218004/diff/7001/tools/dom/scripts/htmleven...
File tools/dom/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/23218004/diff/7001/tools/dom/scripts/htmleven...
tools/dom/scripts/htmleventgenerator.py:331: if attr.type.id == 'EventHandler'
or attr.type.id == 'EventListener']))
line len

Expand Messages | Collapse Messages