Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 232123003: Properly handle errors thrown in [Chain.capture]'s [onError] handler. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly handle errors thrown in [Chain.capture]'s [onError] handler. The Zone infrastructure apparently doesn't automatically pipe errors to the parent Zone (issue 18134). R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
M pkg/stack_trace/lib/src/stack_zone_specification.dart View 1 chunk +14 lines, -3 lines 0 comments Download
M pkg/stack_trace/test/chain_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
6 years, 8 months ago (2014-04-09 22:33:29 UTC) #1
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-09 23:32:39 UTC) #2
kevmoo
On 2014/04/09 23:32:39, Bob Nystrom wrote: > lgtm Update pubspec version? Publish?
6 years, 8 months ago (2014-04-09 23:38:10 UTC) #3
nweiz
On 2014/04/09 23:38:10, kevmoo wrote: > Update pubspec version? Publish? Done.
6 years, 8 months ago (2014-04-09 23:49:05 UTC) #4
nweiz
6 years, 8 months ago (2014-04-09 23:49:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r34904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698