Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 23212003: Relax verification checks. The locale doesn't have to be constant, print (Closed)

Created:
7 years, 4 months ago by Alan Knight
Modified:
7 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Relax verification checks. The locale doesn't have to be constant, print the node in the error message without making assumptions about its type, and do not require the name parameter to match the function name. R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M pkg/intl/lib/src/intl_message.dart View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
7 years, 4 months ago (2013-08-14 20:31:54 UTC) #1
Emily Fortuna
lgtm
7 years, 4 months ago (2013-08-14 20:56:59 UTC) #2
Alan Knight
7 years, 4 months ago (2013-08-14 21:07:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26154 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698