Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1120)

Issue 23204007: Fix casts and type assertions on mixins used in native classes (Closed)

Created:
7 years, 4 months ago by sra1
Modified:
7 years, 3 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix casts and type assertions on mixins used in native classes TBR=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26459

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 1 chunk +5 lines, -3 lines 0 comments Download
A tests/compiler/dart2js_native/subclassing_type_test.dart View 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #1 manually as r26459 (presubmit successful).
7 years, 4 months ago (2013-08-21 19:32:22 UTC) #1
ngeoffray
7 years, 4 months ago (2013-08-22 06:53:33 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698