Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 23202004: Update dart:chrome to include fileSystem, and update summary docs. (Closed)

Created:
7 years, 4 months ago by benwells
Modified:
7 years, 4 months ago
Reviewers:
Kathy Walrath, blois, kathyw
CC:
reviews_dartlang.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Update dart:chrome to include fileSystem, and update summary docs. The dart:chrome library already includes the file system module but this wasn't included properly at the top level of the API object, making it unavailable. The documentation from the generator included in the API has also been updated. BUG=None R=blois@google.com, kathyw@google.com Committed: https://code.google.com/p/dart/source/detail?r=26241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M sdk/lib/chrome/dart2js/chrome_dart2js.dart View 3 chunks +11 lines, -5 lines 0 comments Download
M tools/dom/scripts/chromegenerator.py View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/dom/src/chrome/chrome.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/chrome_dart2js.darttemplate View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
benwells
blois for code changes kathyw for docs changes
7 years, 4 months ago (2013-08-15 08:36:10 UTC) #1
Kathy Walrath
lgtm
7 years, 4 months ago (2013-08-15 15:39:02 UTC) #2
blois
lgtm
7 years, 4 months ago (2013-08-15 22:08:03 UTC) #3
benwells
7 years, 4 months ago (2013-08-15 23:28:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698