Fix absolute paths on Windows without a drive letter.

Fix absolute paths on Windows without a drive letter.


BUG=11946
Committed: https://code.google.com/p/dart/source/detail?r=26201

[zra, 2013-08-14 16:38:12]

Would this be tricky to test?

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart#newc...
runtime/bin/builtin.dart:95: _sanitizeWindowsPath(path) {
If it's easy/makes sense, maybe collect all Windows path futzery in here.
Otherwise, giving a name that has something to do with slashes might make things
a bit more clear.

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart#newc...
runtime/bin/builtin.dart:236: String _filePathFromFileUri(Uri uri) {
It looks like this code is only running under the file: URI scheme. Does
Uri.parse give the file: scheme when no scheme is in the URI?

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart#newc...
runtime/bin/builtin.dart:244: (path[2] != ':')) {
Is this (path[2] != ':') checking that the path is not already of the form
/C:/...? A comment to that effect might be helpful.

[Cutch, 2013-08-14 20:29:08]

Testing this will be tricky on the bots because we have to generate the source
code for the test with the correct import path during the test.

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart#newc...
runtime/bin/builtin.dart:236: String _filePathFromFileUri(Uri uri) {
On 2013/08/14 16:38:12, zra wrote:
> It looks like this code is only running under the file: URI scheme. Does
> Uri.parse give the file: scheme when no scheme is in the URI?

For absolute paths with no scheme, yes.

https://codereview.chromium.org/23199002/diff/1/runtime/bin/builtin.dart#newc...
runtime/bin/builtin.dart:244: (path[2] != ':')) {
On 2013/08/14 16:38:12, zra wrote:
> Is this (path[2] != ':') checking that the path is not already of the form
> /C:/...? A comment to that effect might be helpful.

Done.

[zra, 2013-08-15 15:03:42]

lgtm

https://codereview.chromium.org/23199002/diff/7001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/23199002/diff/7001/runtime/bin/builtin.dart#n...
runtime/bin/builtin.dart:126: 
Not sure what the Dart style is, but everywhere else there are two spaces
between functions.

https://codereview.chromium.org/23199002/diff/7001/runtime/bin/builtin.dart#n...
runtime/bin/builtin.dart:136: 
Here, too.

[Cutch, 2013-08-15 15:44:23]

https://codereview.chromium.org/23199002/diff/7001/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/23199002/diff/7001/runtime/bin/builtin.dart#n...
runtime/bin/builtin.dart:126: 
On 2013/08/15 15:03:42, zra wrote:
> Not sure what the Dart style is, but everywhere else there are two spaces
> between functions.

It's not specified but I should be consistent :)

Done.

https://codereview.chromium.org/23199002/diff/7001/runtime/bin/builtin.dart#n...
runtime/bin/builtin.dart:136: 
On 2013/08/15 15:03:42, zra wrote:
> Here, too.

Done.

[Cutch, 2013-08-15 16:54:04]

Committed patchset #3 manually as r26201 (presubmit successful).