Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 231983004: Fix used vs. capacity growth computation mismatch. (Closed)

Created:
6 years, 8 months ago by koda
Modified:
6 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix used vs. capacity growth computation mismatch. Free space was not being taking into consideration, effectively growing more when more garbage was collected. This change makes the growth uniform. (In the future, we probably want to grow more when less was collected.) R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34909

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M runtime/vm/pages.cc View 1 2 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
koda
6 years, 8 months ago (2014-04-09 23:13:11 UTC) #1
Ivan Posva
LGTM -ip
6 years, 8 months ago (2014-04-10 00:15:12 UTC) #2
koda
As expected, this change makes SplayHarder slower (up to 20%): http://108.170.219.2:8080/Comparison#targetA%3Ddart%3BmachineTypeA%3Dlinux-ia32%3BrevisionA%3D34902%3BpatchA%3Dkoda-math%3BtargetB%3Ddart%3BmachineTypeB%3Dlinux-ia32%3BrevisionB%3D34902%3BpatchB%3DNone This can be counteracted ...
6 years, 8 months ago (2014-04-10 00:15:27 UTC) #3
koda
6 years, 8 months ago (2014-04-10 00:24:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r34909 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698