Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 231973002: Properly check to see if dart2js is generating source maps before declaring them. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly check to see if dart2js is generating source maps before declaring them. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34906

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-09 21:19:08 UTC) #1
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-09 23:34:14 UTC) #2
nweiz
6 years, 8 months ago (2014-04-09 23:54:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698