Issue 23190029: Cleanup of deoptimization environment copying functions.

Issue 23190029: Cleanup of deoptimization environment copying functions. (Closed)

Created:
7 years, 4 months ago by Kevin Millikin (Google)

Modified:
7 years, 3 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanup of deoptimization environment copying functions. Change the deoptimization environment copying functions so that they crash rather than safely copying NULL environments. BUG=https://code.google.com/p/dart/issues/detail?id=12616 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26634

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -11 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGMT https://codereview.chromium.org/23190029/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/23190029/diff/1/runtime/vm/intermediate_language.h#newcode6704 runtime/vm/intermediate_language.h:6704: // Deep copy a non-NULL environment. A 'length' ...

7 years, 4 months ago (2013-08-22 15:45:31 UTC) #2

Kevin Millikin (Google)

https://codereview.chromium.org/23190029/diff/1/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/23190029/diff/1/runtime/vm/intermediate_language.h#newcode6704 runtime/vm/intermediate_language.h:6704: // Deep copy a non-NULL environment. A 'length' parameter ...

7 years, 3 months ago (2013-08-26 08:59:11 UTC) #4

Kevin Millikin (Google)

7 years, 3 months ago (2013-08-26 10:56:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r26634 (presubmit successful).

Expand Messages | Collapse Messages