Add a deploy script based on polymer's transformers.

Add a deploy script based on polymer's transformers.

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26601

[Siggi Cherem (dart-lang), 2013-08-23 01:08:48]

This needs more testing and use, but currently works for TodoMVC. woo hoo!

[Siggi Cherem (dart-lang), 2013-08-23 01:09:59]

FYI - this is based on top of the 'phases' introduced in this other CL:
https://codereview.chromium.org/23011045/ which is not yet submitted in the
repo.

[Jennifer Messerly, 2013-08-23 02:07:00]

really cool to see this transition happening :)

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dart
File pkg/polymer/lib/deploy.dart (right):

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dar...
pkg/polymer/lib/deploy.dart:108: filepath = path.join('out', id.path);
should the "out" folder be configurable?

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dar...
pkg/polymer/lib/deploy.dart:130: new File(outpath).writeAsBytesSync(new
File(inpath).readAsBytesSync());
this might be a good use case for async reading/writing, e.g.:

var futures = [];

... for ... in ... {

  // I think only the writer needs to be closed, not 100% sure tho
  var writer = new File(outpath).openWrite();
  futures.add(writer.addStream(new File(inpath).openRead())
      .then((_) => writer.close()));

... } ...

return Future.wait(futures);

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dar...
pkg/polymer/lib/deploy.dart:188: (const [ 'analyzer_experimental', 'args',
'barback', 'browser', 'csslib',
hmm, I wonder if there's anywhere else we can get this data from to make it more
maintainable. Could we use Pub to get the transitive dependency graph from the
pubspec?

[Siggi Cherem (dart-lang), 2013-08-23 02:30:55]

thanks!

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dart
File pkg/polymer/lib/deploy.dart (right):

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dar...
pkg/polymer/lib/deploy.dart:108: filepath = path.join('out', id.path);
On 2013/08/23 02:07:00, John Messerly wrote:
> should the "out" folder be configurable?

haha, I had a TODO for that, and somehow deleted it by mistake. I went ahead and
added the flag.

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dar...
pkg/polymer/lib/deploy.dart:130: new File(outpath).writeAsBytesSync(new
File(inpath).readAsBytesSync());
On 2013/08/23 02:07:00, John Messerly wrote:
> this might be a good use case for async reading/writing, e.g.:
> 
> var futures = [];
> 
> ... for ... in ... {
> 
>   // I think only the writer needs to be closed, not 100% sure tho
>   var writer = new File(outpath).openWrite();
>   futures.add(writer.addStream(new File(inpath).openRead())
>       .then((_) => writer.close()));
> 
> ... } ...
> 
> return Future.wait(futures);

Nice, Done.

https://codereview.chromium.org/23189016/diff/3001/pkg/polymer/lib/deploy.dar...
pkg/polymer/lib/deploy.dart:188: (const [ 'analyzer_experimental', 'args',
'barback', 'browser', 'csslib',
On 2013/08/23 02:07:00, John Messerly wrote:
> hmm, I wonder if there's anywhere else we can get this data from to make it
more
> maintainable. Could we use Pub to get the transitive dependency graph from the
> pubspec?

Added a TODO.

Pub makes it easy to do this for the application package (with list-package-dirs
or reading the pubspec.lock), but not that easy for a deeper dependency. We
could read the pubspec.yaml files and infer things form there (since we have the
directory location already, we don't need to do any resolution of versions
ourselves, just gather package names).

However, I'm not sure if it's worth it. In the current implementation we won't
have problems if this list becomes inaccurate. As long as we don't have
dependencies in polymer that actually need transformations. In particular, in
the code above we'll skip a package we list here if it doesn't exist (e.g. if we
remove a dependency in the future) and we'll process a package with barback
packages if we don't list it (e.g. if we add a dependency in the future), which
is ok.

[Jennifer Messerly, 2013-08-23 03:03:09]

lgtm

[Siggi Cherem (dart-lang), 2013-08-23 15:59:00]

Committed patchset #2 manually as r26601 (presubmit successful).