Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 23189009: Modify custom elements to inherit from HtmlElement (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
Reviewers:
sra, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Modify custom elements to inherit from HtmlElement R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26275

Patch Set 1 #

Patch Set 2 : Regenerate dart:html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -10 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M tests/html/custom_elements_test.dart View 2 chunks +15 lines, -3 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 4 months ago (2013-08-16 01:13:11 UTC) #1
blois
lgtm
7 years, 4 months ago (2013-08-16 01:14:07 UTC) #2
vsm
7 years, 4 months ago (2013-08-16 15:24:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698