Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 23189002: dart:io | Add test for HttpClient requests that never complete their future. (Closed)

Created:
7 years, 4 months ago by Bill Hesse
Modified:
7 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Add test for HttpClient requests that never complete their future. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26125

Patch Set 1 #

Patch Set 2 : Add suppressions and issue number in standalone.status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -29 lines) Patch
M tests/standalone/io/https_bad_certificate_client.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A tests/standalone/io/https_unauthorized_client.dart View 1 1 chunk +47 lines, -0 lines 0 comments Download
A + tests/standalone/io/https_unauthorized_test.dart View 1 3 chunks +8 lines, -10 lines 0 comments Download
A tests/standalone/io/secure_unauthorized_client.dart View 1 1 chunk +45 lines, -0 lines 0 comments Download
A + tests/standalone/io/secure_unauthorized_test.dart View 1 4 chunks +13 lines, -18 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Added suppression for https_bad_certificate_test failures on MacOS, and added two new tests, that test for ...
7 years, 4 months ago (2013-08-14 14:43:32 UTC) #1
Søren Gjesse
lgtm
7 years, 4 months ago (2013-08-14 14:51:57 UTC) #2
Bill Hesse
7 years, 4 months ago (2013-08-14 15:23:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26125 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698