Issue 231863007: Support local variables in dart2dart.

Issue 231863007: Support local variables in dart2dart. (Closed)

Created:
6 years, 8 months ago by Kevin Millikin (Google)

Modified:
6 years, 7 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support local variables in dart2dart. Other than translating the definitions, local variables are identical to parameters. R=karlklose@google.com, floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34968 Committed: https://code.google.com/p/dart/source/detail?r=35621

Patch Set 2 : Update expected results for a test. #

Patch Set 3 : Incorporated review comments. #

Patch Set 4 : Incorporated review comments. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+403 lines, -126 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View	1 2 3	1 chunk	+12 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree.dart	View	1 2 3	2 chunks	+17 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart	View	1 2 3	15 chunks	+196 lines, -51 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_nodes.dart	View	1 2 3	4 chunks	+84 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_pickler.dart	View	1 2 3	8 chunks	+31 lines, -16 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_tracer.dart	View	1 2 3	9 chunks	+35 lines, -17 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ir/ir_unpickler.dart	View	1 2 3	4 chunks	+28 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

This change depends on https://codereview.chromium.org/233153002/

6 years, 8 months ago (2014-04-10 14:55:40 UTC) #1

karlklose

LGTM. https://codereview.chromium.org/231863007/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart File sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart (right): https://codereview.chromium.org/231863007/diff/1/sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart#newcode439 sdk/lib/_internal/compiler/implementation/ir/ir_builder.dart:439: if (!isOpen) return null; Perhaps add a comment.

6 years, 8 months ago (2014-04-11 09:01:56 UTC) #2

Kevin Millikin (Google)

Thanks for the review. I had to change some test result expectations, so could you ...

6 years, 8 months ago (2014-04-11 10:28:51 UTC) #3

Kevin Millikin (Google)

Committed patchset #3 manually as r34968 (presubmit successful).

6 years, 8 months ago (2014-04-11 10:47:22 UTC) #5

Kevin Millikin (Google)

6 years, 7 months ago (2014-05-01 10:03:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r35621 (presubmit successful).

Expand Messages | Collapse Messages