Issue 23172011: Implement the proxy annotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23172011: Implement the proxy annotation (Closed)

Created:
7 years, 4 months ago by Brian Wilkerson

Modified:
7 years, 4 months ago

Reviewers:
gbracha

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement the proxy annotation. Please verify that the semantics described are as desired. R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=26384

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	pkg/meta/lib/meta.dart	View		1 chunk	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gbracha

lgtm with comments https://codereview.chromium.org/23172011/diff/1/pkg/meta/lib/meta.dart File pkg/meta/lib/meta.dart (right): https://codereview.chromium.org/23172011/diff/1/pkg/meta/lib/meta.dart#newcode59 pkg/meta/lib/meta.dart:59: This seems reasonable to me, though ...

7 years, 4 months ago (2013-08-20 17:39:32 UTC) #2

Brian Wilkerson

I'd be interested in getting your feedback on the question I e-mailed. Specifically, whether @proxy ...

7 years, 4 months ago (2013-08-20 17:48:29 UTC) #3

Brian Wilkerson

7 years, 4 months ago (2013-08-20 19:35:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26384 (presubmit successful).

Expand Messages | Collapse Messages