Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 231603005: Preserve laziness in declaring transformers. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Preserve laziness in declaring transformers. R=rnystrom@google.com BUG=16442 Committed: https://code.google.com/p/dart/source/detail?r=34945

Patch Set 1 #

Total comments: 3

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -29 lines) Patch
M pkg/barback/lib/src/asset_node.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/barback/lib/src/phase.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/barback/lib/src/transform_node.dart View 1 4 chunks +13 lines, -4 lines 0 comments Download
M pkg/barback/test/package_graph/lazy_transformer_test.dart View 1 chunk +53 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 8 months ago (2014-04-10 00:49:22 UTC) #1
Bob Nystrom
One nit then LGTM. https://codereview.chromium.org/231603005/diff/1/pkg/barback/lib/src/transform_node.dart File pkg/barback/lib/src/transform_node.dart (right): https://codereview.chromium.org/231603005/diff/1/pkg/barback/lib/src/transform_node.dart#newcode122 pkg/barback/lib/src/transform_node.dart:122: (transformer is DeclaringTransformer && primary.isLazy) ...
6 years, 8 months ago (2014-04-10 20:45:34 UTC) #2
nweiz
https://codereview.chromium.org/231603005/diff/1/pkg/barback/lib/src/transform_node.dart File pkg/barback/lib/src/transform_node.dart (right): https://codereview.chromium.org/231603005/diff/1/pkg/barback/lib/src/transform_node.dart#newcode122 pkg/barback/lib/src/transform_node.dart:122: (transformer is DeclaringTransformer && primary.isLazy) { On 2014/04/10 20:45:34, ...
6 years, 8 months ago (2014-04-10 20:54:52 UTC) #3
nweiz
6 years, 8 months ago (2014-04-10 20:57:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r34945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698