Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 231603003: Fix an analyzer warning in scheduled_test. (Closed)

Created:
6 years, 8 months ago by nweiz
Modified:
6 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix an analyzer warning in scheduled_test. This also changes the signature of [test] to match that exposed by unittest. R=rnystrom@google.com BUG=18113 Committed: https://code.google.com/p/dart/source/detail?r=34899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 8 months ago (2014-04-09 19:45:04 UTC) #1
Bob Nystrom
lgtm
6 years, 8 months ago (2014-04-09 20:23:58 UTC) #2
nweiz
6 years, 8 months ago (2014-04-09 21:20:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34899 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698