Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 23159007: Properly parse V8 stack traces that contain the exception description. (Closed)

Created:
7 years, 4 months ago by nweiz
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly parse V8 stack traces that contain the exception description. R=rnystrom@google.com BUG=12151 Committed: https://code.google.com/p/dart/source/detail?r=26395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M pkg/stack_trace/lib/src/trace.dart View 3 chunks +15 lines, -2 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 4 months ago (2013-08-20 21:09:06 UTC) #1
Bob Nystrom
LGTM!
7 years, 4 months ago (2013-08-20 21:30:16 UTC) #2
nweiz
7 years, 4 months ago (2013-08-20 21:41:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698