Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 23151005: Move _HTMLElement to HtmlElement (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
Reviewers:
sra, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move _HTMLElement to HtmlElement The old HtmlElement is now HtmlHtmlElement. The custom tests don't break for now. I'll modify them in a separate CL to inherit from HtmlElement instead. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26248

Patch Set 1 #

Patch Set 2 : Regen dart:html #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -333 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 79 chunks +90 lines, -90 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 78 chunks +238 lines, -238 lines 0 comments Download
M tests/html/element_types_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vsm
7 years, 4 months ago (2013-08-16 00:12:50 UTC) #1
blois
lgtm
7 years, 4 months ago (2013-08-16 00:34:41 UTC) #2
vsm
7 years, 4 months ago (2013-08-16 00:46:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698