Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 231413003: using unittest via package import (Closed)

Created:
6 years, 8 months ago by kevmoo
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -233 lines) Patch
M tests/_chrome/sample_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/async_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audiobuffersourcenode_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audiocontext_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/audioelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/b_element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/blob_constructor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cache_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/callbacks_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_pixel_array_type_alias_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvas_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/canvasrenderingcontext2d_test.dart View 1 1 chunk +5 lines, -2 lines 0 comments Download
M tests/html/cdata_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/client_rect_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cross_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/crypto_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/css_rule_list_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/css_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/custom_tags_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dart_object_local_storage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/datalistelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/document_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/documentfragment_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dom_constructors_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/domparser_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/dromaeo_noop/dromaeo_smoke.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M tests/html/dromaeo_smoke_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_add_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_constructor_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_offset_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/element_types_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_customevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/exceptions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/fileapi_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/form_data_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/form_element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/geolocation_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/hidden_dom_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/hidden_dom_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/history_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlcollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmlelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/htmloptionscollection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/indexeddb_5_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/input_element_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/instance_of_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/interactive_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/isolates_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_interop_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/js_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/keyboard_event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/localstorage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/location_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/media_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/messageevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/mouse_event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/mutationobserver_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/native_gc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/navigator_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/non_instantiated_is_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/performance_api_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/postmessage_structured_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/query_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/queryall_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/range_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/request_animation_frame_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/rtc_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/selectelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/serialized_script_value_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/shadow_dom_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/shadowroot_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/speechrecognition_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/storage_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/streams_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/table_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/touchevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/transferables_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/transition_event_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_5_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_arraybuffer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_range_checks_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typed_arrays_simd_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/typing_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/unknownelement_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/uri_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/url_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/util.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/webgl_1_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/websocket_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/websql_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/wheelevent_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_eq_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_mangling_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_nosuchmethod_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/window_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/worker_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/xsltprocessor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/spawn_uri_nested_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/spawn_uri_vm_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
Required for coming changes to unittest, which uses mini-libraries Also just...better...
6 years, 8 months ago (2014-04-09 19:16:40 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/231413003/diff/1/tests/benchmark_smoke/benchmark_smoke_test.dart File tests/benchmark_smoke/benchmark_smoke_test.dart (right): https://codereview.chromium.org/231413003/diff/1/tests/benchmark_smoke/benchmark_smoke_test.dart#newcode11 tests/benchmark_smoke/benchmark_smoke_test.dart:11: import '../../pkg/expect/lib/expect.dart'; this one too? :) https://codereview.chromium.org/231413003/diff/1/tests/html/canvasrenderingcontext2d_test.dart File ...
6 years, 8 months ago (2014-04-09 19:28:57 UTC) #2
kevmoo
https://codereview.chromium.org/231413003/diff/1/tests/benchmark_smoke/benchmark_smoke_test.dart File tests/benchmark_smoke/benchmark_smoke_test.dart (right): https://codereview.chromium.org/231413003/diff/1/tests/benchmark_smoke/benchmark_smoke_test.dart#newcode11 tests/benchmark_smoke/benchmark_smoke_test.dart:11: import '../../pkg/expect/lib/expect.dart'; On 2014/04/09 19:28:58, Siggi Cherem (dart-lang) wrote: ...
6 years, 8 months ago (2014-04-09 19:41:08 UTC) #3
kevmoo
6 years, 8 months ago (2014-04-09 19:43:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r34890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698