Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 23140003: Rename CompositeMessage's named parent constructor. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna
Modified:
7 years, 4 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, janicejl
Visibility:
Public.

Description

Rename CompositeMessage's named parent constructor. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=26101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/intl/lib/src/intl_message.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
The dart2js mirrors caught this problem. CompositeMessage extends Message. Message has a field called "parent", ...
7 years, 4 months ago (2013-08-14 00:13:58 UTC) #1
Alan Knight
lgtm
7 years, 4 months ago (2013-08-14 00:30:28 UTC) #2
Emily Fortuna
7 years, 4 months ago (2013-08-14 00:33:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698