Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 23133004: Support "..." VM frames in pkg/stack_trace. (Closed)

Created:
7 years, 4 months ago by nweiz
Modified:
7 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support "..." VM frames in pkg/stack_trace. Also include the original stack trace when a parse error occurs. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=26132

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 1 chunk +13 lines, -8 lines 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 4 months ago (2013-08-14 00:31:33 UTC) #1
Bob Nystrom
LGTM!
7 years, 4 months ago (2013-08-14 15:57:59 UTC) #2
nweiz
7 years, 4 months ago (2013-08-14 18:10:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26132 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698