Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 23133003: Fix ClassMirror.typeArguments handling for dynamic only type arguments (Closed)

Created:
7 years, 4 months ago by Michael Lippautz (Google)
Modified:
7 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Fix ClassMirror.typeArguments handling for dynamic only type arguments. Addresses an issue where we did not return the appropriate type arguments for instances with all dynamic type arguments. Example: Class <E> {} main() { var cm = reflectClass(new C()).type; print(cm.typeArguments); // now prints: {Symbol("E"): TypeMirror on 'dynamic'} // previously: crashed } BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26135

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M runtime/lib/mirrors.cc View 1 2 1 chunk +21 lines, -7 lines 0 comments Download
M tests/lib/mirrors/generics_test.dart View 5 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Lippautz (Google)
7 years, 4 months ago (2013-08-14 00:04:15 UTC) #1
rmacnak
https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc#newcode598 runtime/lib/mirrors.cc:598: if (num_params == 0) return Object::empty_array().raw(); While I think ...
7 years, 4 months ago (2013-08-14 00:07:41 UTC) #2
Michael Lippautz (Google)
https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc#newcode598 runtime/lib/mirrors.cc:598: if (num_params == 0) return Object::empty_array().raw(); On 2013/08/14 00:07:41, ...
7 years, 4 months ago (2013-08-14 00:14:08 UTC) #3
siva
https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc#newcode607 runtime/lib/mirrors.cc:607: // arguments have been provided, or all arguments have ...
7 years, 4 months ago (2013-08-14 00:22:09 UTC) #4
Michael Lippautz (Google)
https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/23133003/diff/1/runtime/lib/mirrors.cc#newcode607 runtime/lib/mirrors.cc:607: // arguments have been provided, or all arguments have ...
7 years, 4 months ago (2013-08-14 16:29:29 UTC) #5
siva
lgtm
7 years, 4 months ago (2013-08-14 18:30:53 UTC) #6
Michael Lippautz (Google)
7 years, 4 months ago (2013-08-14 18:41:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r26135 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698