Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 23129014: Add packed add and subtract to IA32 and X64 assemblers (Closed)

Created:
7 years, 4 months ago by Cutch
Modified:
7 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add packed add and subtract to IA32 and X64 assemblers R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26325

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -12 lines) Patch
M runtime/vm/assembler_ia32.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32_test.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 2 chunks +14 lines, -11 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
7 years, 4 months ago (2013-08-19 19:05:02 UTC) #1
srdjan
lgtm
7 years, 4 months ago (2013-08-19 19:53:34 UTC) #2
Cutch
7 years, 4 months ago (2013-08-19 19:57:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r26325 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698