Issue 23129005: Remove int.pow and double.pow from VM library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23129005: Remove int.pow and double.pow from VM library. (Closed)

Created:
7 years, 4 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove int.pow and double.pow from VM library. BUG= http://dartbug.com/10268 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=26340

Patch Set 2 : Fixed Math.pow to not use int.pow,double.pow. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -46 lines)			Patch
M	runtime/lib/double.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	runtime/lib/double.dart	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	runtime/lib/integers.dart	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	runtime/lib/math.cc	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/lib/math_patch.dart	View	1	1 chunk	+35 lines, -3 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/23129005/diff/1/runtime/lib/double.dart File runtime/lib/double.dart (left): https://codereview.chromium.org/23129005/diff/1/runtime/lib/double.dart#oldcode142 runtime/lib/double.dart:142: double _pow(double exponent) native "Double_pow"; Can/should Double_pow also be ...

7 years, 4 months ago (2013-08-16 11:51:05 UTC) #1

Lasse Reichstein Nielsen

Whaddayaknow - int.pow and double.pow were used in math.pow. Rewrote math.pow to use existing code. ...

7 years, 4 months ago (2013-08-16 12:37:36 UTC) #2

Lasse Reichstein Nielsen

7 years, 4 months ago (2013-08-20 08:13:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26340 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23129005: Remove int.pow and double.pow from VM library. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fixed Math.pow to not use int.pow,double.pow. #

Messages