Ensure the type inferrer does not infer types for runtime helpers used by the backend.

Ensure the type inferrer does not infer types for runtime helpers used by the backend.

R=ahe@google.com, karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26180

[ahe, 2013-08-15 09:41:07]

LGTM!

https://codereview.chromium.org/23118007/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/23118007/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:865:
if (analyzedElement.isParameter() || analyzedElement.isFieldParameter()) {
I wonder if this check should be moved to canBeUsedForGlobalOptimizations?

https://codereview.chromium.org/23118007/diff/1/tests/compiler/dart2js_native...
File tests/compiler/dart2js_native/inference_of_helper_methods_test.dart
(right):

https://codereview.chromium.org/23118007/diff/1/tests/compiler/dart2js_native...
tests/compiler/dart2js_native/inference_of_helper_methods_test.dart:21:
intTypeCheck(42);
Could you explain what this method does, and how this would be broken before?

[karlklose, 2013-08-15 09:41:47]

LGTM.

[ngeoffray, 2013-08-15 09:46:04]

Thanks Karl and Peter.

https://codereview.chromium.org/23118007/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart
(right):

https://codereview.chromium.org/23118007/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:865:
if (analyzedElement.isParameter() || analyzedElement.isFieldParameter()) {
On 2013/08/15 09:41:07, ahe wrote:
> I wonder if this check should be moved to canBeUsedForGlobalOptimizations?

Good point. Done.

https://codereview.chromium.org/23118007/diff/1/tests/compiler/dart2js_native...
File tests/compiler/dart2js_native/inference_of_helper_methods_test.dart
(right):

https://codereview.chromium.org/23118007/diff/1/tests/compiler/dart2js_native...
tests/compiler/dart2js_native/inference_of_helper_methods_test.dart:21:
intTypeCheck(42);
On 2013/08/15 09:41:07, ahe wrote:
> Could you explain what this method does, and how this would be broken before?

Done.

[ahe, 2013-08-15 09:52:25]

https://codereview.chromium.org/23118007/diff/1/tests/compiler/dart2js_native...
File tests/compiler/dart2js_native/inference_of_helper_methods_test.dart
(right):

https://codereview.chromium.org/23118007/diff/1/tests/compiler/dart2js_native...
tests/compiler/dart2js_native/inference_of_helper_methods_test.dart:21:
intTypeCheck(42);
On 2013/08/15 09:46:04, ngeoffray wrote:
> On 2013/08/15 09:41:07, ahe wrote:
> > Could you explain what this method does, and how this would be broken
before?
> 
> Done.

Thank you, the explanation makes sense to me.

[ngeoffray, 2013-08-15 10:06:15]

Committed patchset #2 manually as r26180 (presubmit successful).