Simplify access to peer pointer for external strings.

Simplify access to peer pointer for external strings.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26202

[srdjan, 2013-08-15 01:47:06]

LGTM with comments/questions.

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:243: #define GET_PEER(type, ctype, raw_obj, peer)   
                               \
I am not certain if for only two cases it is worth to add the macro.

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:251: #define EXTERNAL_PEER_HELPER(cid, raw_obj,
peer)                               \
Can this be a function instead of a macro?

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.h
File runtime/vm/dart_api_impl.h (right):

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.h...
runtime/vm/dart_api_impl.h:195: int arg_index,
s/int/intptr_t/ ?

[siva, 2013-08-15 17:05:18]

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:243: #define GET_PEER(type, ctype, raw_obj, peer)   
                               \
Femoved macro and inlined the code in the other call.

On 2013/08/15 01:47:06, srdjan wrote:
> I am not certain if for only two cases it is worth to add the macro.

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.c...
runtime/vm/dart_api_impl.cc:251: #define EXTERNAL_PEER_HELPER(cid, raw_obj,
peer)                               \
Would have loved to make it a function but that would mean we would have a raw
pointer passed in as an argument and it would have been difficult to put the
NoGcScope construct at the right place. 
By having it as a macro I am able to put a NoGCScope around this code.

On 2013/08/15 01:47:06, srdjan wrote:
> Can this be a function instead of a macro?

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.h
File runtime/vm/dart_api_impl.h (right):

https://codereview.chromium.org/23118006/diff/8001/runtime/vm/dart_api_impl.h...
runtime/vm/dart_api_impl.h:195: int arg_index,
On 2013/08/15 01:47:06, srdjan wrote:
> s/int/intptr_t/ ?

The Dart C API uses 'int' for all native argument indexes. I am trying to
think why it was done like that (maybe to avoid have dartium code having to use
intptr_t all over the place). At any rate I will check and see if it makes sense
to uniformly change this to 'intptr_t' in the API

[siva, 2013-08-15 17:10:29]

Committed patchset #4 manually as r26202 (presubmit successful).